Misc lint fixes #1020
Merged
Misc lint fixes #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangg12
reviewed
Aug 2, 2019
| @@ -101,7 +101,7 @@ def __len__(self): | |||
| collate_fn=lambda x: x[0]) | |||
| aspect_ratios = [] | |||
| with tqdm(total=len(dataset)) as pbar: | |||
| for i, (img, _) in enumerate(data_loader): | |||
| for _i, (img, _) in enumerate(data_loader): | |||
| pbar.update(1) | |||
| height, width = img.shape[-2:] | |||
| aspect_ratio = float(height) / float(width) | |||
There was a problem hiding this comment.
@fmassa Shouldn't aspect_ratio be width/height?
There was a problem hiding this comment.
I think the important thing in here is for it to be consistent between all the implementations, and I don't think it will change anything in this particular case.
There was a problem hiding this comment.
Well, it just looks weid to understand because it is different from other definition.
There was a problem hiding this comment.
I believe we can change this definition here without breaking the rest of the code. I would be willing to merge a PR that do this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those minor lint issues were caught when running tests in fb